Merged
Conversation
eggplants
force-pushed
the
drop-python-3.9
branch
2 times, most recently
from
4030c19 to
dd2dc7f
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR drops Python 3.9 support and makes jdk4py a required dependency instead of optional, improving portability by bundling Java runtime with the package.
- Removes Python 3.9 support and updates minimum required version to 3.10
- Makes jdk4py a required dependency instead of optional
- Simplifies Java runtime detection by removing fallback to system Java
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Updates Python version requirements and makes jdk4py a required dependency |
| openapi_generator_cli/init.py | Removes Java detection fallback logic and imports jdk4py directly |
| README.md | Updates installation instructions to reflect jdk4py as default |
| .pre-commit-config.yaml | Updates pre-commit hook versions |
| .github/workflows/test.yaml | Removes Python 3.9 from test matrix and Java setup step |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Member
|
thanks for the PR given that python 3.9 is still supported (https://endoflife.date/python, last release in jun 2025) shall we keep it for another 2 months before dropping its support? |
eggplants
force-pushed
the
drop-python-3.9
branch
from
7ac7c5d to
3a5c1fb
Compare
eggplants
force-pushed
the
drop-python-3.9
branch
from
03a301f to
1420054
Compare
Member
Author
|
@wing328 Please review 🙏 |
wing328
approved these changes
Nov 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Merge after 31 Oct 2025
fixes: #33
Drop Python 3.9
and use.jdk4pyas default for portabilityEdit:
jdk4pysupports only a limited number of architectures, and if it is made mandatory, it will no longer work on Android or Windows on ARM, for example. Therefore, I would like to make it optional again.After merged,
7.14.0.post0